Embed some data files in libxamarin-app.so
#9367
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
5 times, most recently
from
2730842 to
40a46b6
Compare
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
4 times, most recently
from
6a18219 to
c69913c
Compare
grendello
requested review from
dellis1972 and
jonathanpeppers
as code owners
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
from
b64f9e9 to
f31d1a1
Compare
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
5 times, most recently
from
bafa9e1 to
d76969a
Compare
dellis1972
reviewed
Oct 23, 2024
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
from
d76969a to
c450cb6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonpryor
reviewed
Oct 25, 2024
src/Xamarin.Android.Build.Tasks/Mono.Android/ApplicationAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
2 times, most recently
from
f2d1748 to
04b4ab8
Compare
src/Xamarin.Android.Build.Tasks/Mono.Android/InstrumentationAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/ApplicationAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/PermissionAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/PermissionGroupAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/PermissionTreeAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/SupportsGLTextureAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/UsesFeatureAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Mono.Android/UsesPermissionAttribute.Partial.cs
Outdated
Show resolved
Hide resolved
Even though we might not have any content to embed, we need the symbols to be present, because they're part of the `libxamarin-app.so` ABI expected by `libmonodroid.so`
This reverts commit bc47870. It broke 481 tests
grendello
force-pushed
the
dev/grendel/embed-binaries-in-xamarinapp
branch
from
c584dbd to
a1665db
Compare
|
Was bitrotten, needs TLC after rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime blob config and assembly store are two candidates for embedding now.
If these two files are embedded in
libxamarin-app.so, we can skip scanning theAPK for them and, potentially, speed up startup.
Changes implemented here give us a 2% speed up on the Displayed metrics, 2.7% on
the "Native to managed" metrics and 2% on the "Total runtime init" metrics.
Tests were performed on Pixel 6 Pro, using the
dotnet new androidtemplate.